Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add remark-gfm plugin #2171

Merged
merged 6 commits into from
Jul 10, 2023
Merged

feat: Add remark-gfm plugin #2171

merged 6 commits into from
Jul 10, 2023

Conversation

ozandogrultan
Copy link
Contributor

Description

Adding the remark-gfm plugin in order to support Github Flavored markdown in EditableText component

Motivation and Context

This will allow users to render Github flavored markdown (tables, autolink literals etc) properly

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@ozandogrultan
feat: Add remark-gfm plugin
d115a9e 
Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan
feat: Revert package-lock changes
fd09d44 
Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan
feat: package-lock changes
b9c2a9f 
Signed-off-by: Ozan Dogrultan <[email protected]>
@ozandogrultan
feat: revert change
296dead 
Signed-off-by: Ozan Dogrultan <[email protected]>
@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Jul 3, 2023
Golodhros
Golodhros approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozandogrultan ozandogrultan merged commit 00e3477 into amundsen-io:main Jul 10, 2023
@ozandogrultan ozandogrultan mentioned this pull request Jul 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@kristenarmes kristenarmes Awaiting requested review from kristenarmes kristenarmes is a code owner

@B-T-D B-T-D Awaiting requested review from B-T-D B-T-D is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozandogrultan @Golodhros