Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose healthz port or something for health check #186

Closed
alin04 opened this issue Nov 5, 2018 · 7 comments
Closed

expose healthz port or something for health check #186

alin04 opened this issue Nov 5, 2018 · 7 comments
Assignees

Comments

@alin04
Copy link
Collaborator

alin04 commented Nov 5, 2018

No description provided.

@ireinhart
Copy link

Hello,

we are trying to use the amppackager for our site. Is it possible to add a small health check endpoint? We like to monitor the service and use the kubernetes livenessProbe.

@alin04
Copy link
Collaborator Author

alin04 commented Apr 2, 2019

Yes, that was the idea - to support containers like kubernetes and Docker.

The thought is to check the cert cache is healthy and the rtv cache is up-to-date.

We probably won't be able to address this for another month or so. Feel free to submit a PR.

@Gregable Gregable self-assigned this Aug 5, 2019
@FranGM
Copy link

FranGM commented Oct 21, 2019

Hey, since this issues seems to be in progress I thought I'd ask what's the status/ETA on this?

If we know when to expect (or don't expect) the health check endpoint to be available we can make a decision on how to work around it or not.

@Gregable
Copy link
Member

I picked this up during a Fixit week we had ~2 months ago, but was interrupted and did not make much progress. It has languished since.

@twifkak @banaag do you think a basic health check could be prioritized in the near future? The main things to verify are probably that reading the toml didn't fail, we have a valid certificate, and OCSP response.

@banaag
Copy link
Collaborator

banaag commented Oct 21, 2019

How soon is this needed? I'm ok to pick this up after I'm done with the cert related items I'm working on.

@Gregable
Copy link
Member

I don't have a particular deadline in mind. @FranGM what would be a useful timeline for you to avoid having to work around this?

@FranGM
Copy link

FranGM commented Oct 21, 2019

I think we're looking at around 2-3 weeks for going live. Can probably live with something like a port check for dev/testing but before we get to production we'll certainly want something a tad more robust, which is why I'm trying to plan ahead a little bit.

@banaag banaag assigned banaag and unassigned Gregable Oct 22, 2019
@banaag banaag closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants