Set pan-y on root to enable passive touch handlers #4895
Conversation
| // TODO(dvoytenko, #4894): Cleanup the experiment by moving this to CSS: | ||
| // `html {touch-action: pan-y}` | ||
| if (isExperimentOn(this.win_, 'pan-y')) { | ||
| setStyle(this.win_.document.documentElement, 'touch-action', 'pan-y'); |
|
LGTM |
| // `html {touch-action: pan-y}` (will require adding `amp-embedded` class). | ||
| // The enables passive touch handlers, e.g. for document swipe, since they | ||
| // no will longer need to try to cancel vertical scrolls during swipes. | ||
| if (viewer.isEmbedded() && isExperimentOn(this.win_, 'pan-y')) { |
There was a problem hiding this comment.
is there a harm in doing it in non-embed cases?
(IMO, the less we differ in embed vs non-embed modes, the better. For example we may introduce some code that having pan-y breaks it, but since we primarily test in non-embed case during dev, so it might go unnoticed for longer than it should)
There was a problem hiding this comment.
We'll lose pinch-zoom on Chrome.
There was a problem hiding this comment.
that's a good reason. Maybe document that and mention that in embed mode we already have lost pinch zoom, so it won't be a problem.
There was a problem hiding this comment.
Cool. Added more docs. Also, really, this is only needed when doc is embedded - otherwise there's no document swipe or things like that.
* Set pan-y on root to enable passive touch handlers * more docs * Only set touch-action for embedded cases * more docs
* Set pan-y on root to enable passive touch handlers * more docs * Only set touch-action for embedded cases * more docs
Partial for #4820.
/cc @RByers @cramforce
/cc @ericlindley-g heads up: we will need testing help to launch this.