-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Facebook post embed #979
Comments
Facebook will probably never help develop this. So is there an alternative route? |
@systemaddict I don't actually agree that they'd never do it, but such an embed doesn't necessarily need to be made by Facebook. The same implementation strategy we use for tweets should be fine. |
Please prioritise embedded posts: https://developers.facebook.com/docs/plugins/embedded-posts and embedded videos: https://developers.facebook.com/docs/plugins/embedded-video-player since they tend to be essential to articles like: http://www.n-tv.de/wirtschaft/Mark-Zuckerberg-ist-jetzt-ein-besserer-Mensch-article16485106.html and http://www.buzzfeed.com/assmamaad/la-fille-de-mark-zuckerberg-est-une-fan-de-star-wars |
Use case: Support news articles about what Mark Zuckerberg posted on Facebook :) We should definitely do this and it should be easy enough. Probably similar to |
Here's some examples of a pages where we use Facebook embeds at The Huffington Post: Generally, we grab the url of the post itself and wrap it in some embed code. Ideally, like everyone has mentioned, it should work like |
I have a change that's almost ready. Just fixing up some tests to send with it for a PR. I went the amp-twitter approach few exceptions. One is that the only way I got FB SDK to render posts correctly when there are multiple Before that, following As I mentioned the only way I got this to work and render sizes correctly is by including the sdk and calling FB.init in every amp-facebook iframe. Another issue that I bumped into early on was the inability to access Luckily FB SDK has an alternative for Over all, FB SDK lack of a twitter-like programatic way to create posts I'll send the PR once I get the tests to pass and I can address any concerns needed. |
Per publisher request. More info: https://developers.facebook.com/docs/plugins/embedded-posts
Idea would be for it to be similar to
amp-twitter
oramp-pinterest
.The text was updated successfully, but these errors were encountered: