Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn experiments.js into a service #8970

Closed
lannka opened this issue Apr 26, 2017 · 9 comments
Closed

Turn experiments.js into a service #8970

lannka opened this issue Apr 26, 2017 · 9 comments
Assignees
Milestone

Comments

@lannka
Copy link
Contributor

lannka commented Apr 26, 2017

2 reasons:

  1. experiments.js right now is a shared code between extensions. Each extension toggles experiments independently to each other, and the results are not shared, which can be an issue that different extension will have different experiment on/off status.
  2. experiments.js is now 300+ lines of code. Due to its popularity, it's compiled into almost half of the extensions, which is a waste of bandwidth.

@dvoytenko @erwinmombay thoughts?

@dvoytenko
Copy link
Contributor

I think we can make it a service. Duplication over extensions is definitely problematic especially b/c the set of toggles can diverge. One possible nuance that we may need to work around - the same library is used also experiments.html, which is not otherwise governed by an AMP Runtime. So, that might cause some compilation issues.

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @dvoytenko Do you have any updates?

2 similar comments
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @dvoytenko Do you have any updates?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @dvoytenko Do you have any updates?

@dvoytenko dvoytenko assigned lannka and unassigned dvoytenko Jul 20, 2018
@lannka
Copy link
Contributor Author

lannka commented Aug 3, 2018

in the spirit of moving shared code to service, @jridgewell would you like to take this ?

@lannka lannka assigned jridgewell and unassigned lannka Aug 3, 2018
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @jridgewell Do you have any updates?

@lannka
Copy link
Contributor Author

lannka commented Aug 1, 2019

@kristoferbaxter what do you think about prioritizing this in the upcoming fixit summit? It's going to save quite a lot bytes in each extension.

@kristoferbaxter
Copy link
Contributor

I'll add it to the performance wg list for fixit and see if we can do it.

@stale
Copy link

stale bot commented Jan 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 27, 2021
@stale stale bot closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants