-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn experiments.js into a service #8970
Comments
I think we can make it a service. Duplication over extensions is definitely problematic especially b/c the set of toggles can diverge. One possible nuance that we may need to work around - the same library is used also |
This issue hasn't been updated in awhile. @dvoytenko Do you have any updates? |
2 similar comments
This issue hasn't been updated in awhile. @dvoytenko Do you have any updates? |
This issue hasn't been updated in awhile. @dvoytenko Do you have any updates? |
in the spirit of moving shared code to service, @jridgewell would you like to take this ? |
This issue hasn't been updated in awhile. @jridgewell Do you have any updates? |
@kristoferbaxter what do you think about prioritizing this in the upcoming fixit summit? It's going to save quite a lot bytes in each extension. |
I'll add it to the performance wg list for fixit and see if we can do it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
2 reasons:
experiments.js
right now is a shared code between extensions. Each extension toggles experiments independently to each other, and the results are not shared, which can be an issue that different extension will have different experiment on/off status.experiments.js
is now 300+ lines of code. Due to its popularity, it's compiled into almost half of the extensions, which is a waste of bandwidth.@dvoytenko @erwinmombay thoughts?
The text was updated successfully, but these errors were encountered: