Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send error report if AMP document is rendered into 0 dimensions container #8044

Closed
cramforce opened this issue Mar 9, 2017 · 1 comment
Closed

Send error report if AMP document is rendered into 0 dimensions container #8044

cramforce opened this issue Mar 9, 2017 · 1 comment
Labels
Closed: Duplicate P0: Drop Everything P1: High Priority
Milestone
Pending Triage

Comments

@cramforce
Copy link
Member

We've now had at least 2 regressions where pre-render container rendered AMP into iframes that are display:none and hence have no dimensions. This breaks pre-rendering as we consider nothing to be in viewport.

We should throw an error (out of execution flow) if we discover this, so that we can quickly discover such regressions.

CC @dvoytenko
@cramforce cramforce added this to the Pending Triage milestone Mar 9, 2017
@dvoytenko dvoytenko mentioned this issue Mar 10, 2017
Merged
@dvoytenko
Copy link
Contributor

Duplicate of #8926.

@dvoytenko dvoytenko marked this as a duplicate of #8926 Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed: Duplicate P0: Drop Everything P1: High Priority
Projects
None yet
Milestone
Pending Triage
Development

No branches or pull requests
3 participants
@cramforce @dvoytenko @cvializ