Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @suppress from addeventListeners / replace Object by addEventListenerOptions when compiler externs are updated #5105

Closed
aghassemi opened this issue Sep 19, 2016 · 1 comment
Closed

Remove @suppress from addeventListeners / replace Object by addEventListenerOptions when compiler externs are updated #5105

aghassemi opened this issue Sep 19, 2016 · 1 comment
Assignees
@erwinmombay @aghassemi
Labels
P1: High Priority
Milestone
Sprint H2 September

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Sep 19, 2016 •
edited by wassgha
Loading

We have a polyfill for addEventListener that allows third argument to be an object We changed the addEventListener wrappers to allow changing the passive option but closure compiler externs are still the old API and there is no easy way to override builtin extern in our custom extern file to adhere to the new signature.

Closure compiler team is considering to update the externs ( google/closure-compiler#1959 ) when/if that's merged in, we should update our compiler and remove @suppress flags added as work-around.
@aghassemi aghassemi self-assigned this Sep 19, 2016
@aghassemi aghassemi changed the title Remove @supress from addeventListeners when compiler externs are updated Remove @suppress from addeventListeners when compiler externs are updated Sep 19, 2016
@aghassemi aghassemi mentioned this issue Sep 20, 2016
Closed
@aghassemi
Copy link
Contributor Author

aghassemi commented Sep 26, 2016 •
edited by wassgha
Loading

Not Applicable anymore. No longer polyfilling in favor of our custom listener functions.

@wassgha wassgha mentioned this issue Aug 10, 2017
Merged
@wassgha wassgha reopened this Aug 10, 2017
@wassgha wassgha changed the title Remove @suppress from addeventListeners when compiler externs are updated Remove @suppress from addeventListeners / replace Object by addEventListenerOptions when compiler externs are updated Aug 14, 2017
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Sep 12, 2017
@aghassemi aghassemi mentioned this issue Sep 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwinmombay erwinmombay

@aghassemi aghassemi

Labels
P1: High Priority
Projects
None yet
Milestone
Sprint H2 September
Development

No branches or pull requests
4 participants
@erwinmombay @wassgha @aghassemi @ampprojectbot