Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Brid player to TargetVideo #40130

Closed
danijel-ristic opened this issue Sep 2, 2024 · 5 comments · Fixed by #40151
Closed

Rename Brid player to TargetVideo #40130

danijel-ristic opened this issue Sep 2, 2024 · 5 comments · Fixed by #40151
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code

Comments

@danijel-ristic
Copy link
Contributor

Summary

Rename amp-brid-player to amp-target-video-player

Design Document

No response

Motivation

Brid.tv got acquired by TargetVideo so we need to rename amp-brid-player to amp-target-video-player

Alternative Solutions

Since we need to keep amp-brid-player working until we migrate all amp players to TargetVideo, I guess I need to create new TargetVideo player extension and after we migrate I need to create new PR to remove amp-brid-player, can anyone confirm if this is correct process for doing this.

Launch Tracker

No response

Notifications

/cc @ampproject/wg-approvers

@danijel-ristic danijel-ristic added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Sep 2, 2024
@danijel-ristic
Copy link
Contributor Author

danijel-ristic commented Sep 2, 2024

cc @ampproject/wg-approvers

@danijel-ristic
Copy link
Contributor Author

danijel-ristic commented Sep 6, 2024

cc @erwinmombay @powerivq @ychsieh

@powerivq
Copy link
Contributor

powerivq commented Sep 9, 2024

@danijel-ristic Yes, you should move the extension to the new name, and set the old one as an alias.

@danijel-ristic
Copy link
Contributor Author

@powerivq How would I alias old one to the new one, I tried to find examples, docs but I wasn't lucky. Could you point me in the right direction? Thanks in advance.

@powerivq
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants