Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 🐛 [amp story 360] Remove GL context handling #38144

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

processprocess
Copy link
Contributor

This PR removes the context handling code from the 360 component.
Removing this code is not a final solution but will allow 360 to work in most use cases until the root of the bug is resolved.

Additional context:
GL context handling was implemented to lose and restore web gl context based on distance from the active page. Browsers limit contexts to 8-16. Web Stories that feature 360 such as this one use less than the maximum.

This context handling broke within the past several months. Context is not restored and a blank screen is displayed. In some cases context is created but then lost right after.

The codepen example still works which leads me to believe it's a race condition within the amp story codebase. I'm unable to identify the cause of this bug at this time.

cc @t0mg

@amp-owners-bot
Copy link

Hey @gmajoulet, @t0mg! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js

Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the code behind an experiment flag, so it's easier to bring it back if we decide to spend more time debugging the race condition?
We could also just revert this revert, so still LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants