🐛 [Story attachment] Fix cta-image=none showing link icon

[mszylkowski]

The cta-image=none on outlinks should hide the link icon, but due to a regression on #36706 the link icon was being shown. This PR hides the icon if cta-image=none for the open-page-attachment UI.

Added tests to verify this behavior so it's not broken in the future.

It now works (vis diff for no-image CTA was wrong before):

[amp-owners-bot]

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js

[processprocess]

Thank you for catching, fixing and adding the unit test.

[gmajoulet]

Can you link the bug report, with real world Story examples?

Is cta-image="none" a valid URL giving a valid AMP document that we've been supporting?

amphtml/extensions/amp-story/validator-amp-story.protoascii

Lines 908 to 914 in c813c13

	attrs: {
	name: "cta-image"
	value_url: {
	protocol: "http"
	protocol: "https"
	}
	}

[mszylkowski]

Can you link the bug report, with real world Story examples?

The bug was reported on Slack (so no issue I think), and could be tested with the local story attachment.html.

The validation seems to confirm the attribute set to "none" is valid, though I don't know exactly where this validation rule comes from. https://validator.ampproject.org/ seems to agree that it's valid AMP.

amphtml/extensions/amp-story/1.0/test/validator-amp-story-page-attachment.out

Line 80 in c813c13

| cta-image="none"