-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 amp-story-shopping does not display CTA if all tags are invalid and Fixes remote shopping data loading on refresh with page attachment open #38035
Conversation
Hey @gmajoulet! These files were changed:
Hey @newmuis! These files were changed:
|
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
Outdated
Show resolved
Hide resolved
This is an async problem that can be fixed by refactoring the promise in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach prevents the error from throwing but it doesn't fix the async problem.
On refresh sometimes the attachment will not display.
Please see the Promise.all approach.
Check out the approach in #38090 and how it uses |
A follow up PR to #37503 after config validation was added.
Closes #38034 and #38040