-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Story Preview] Allow all story pages and grid layers to be rendered in preview mode #38030
✨ [Story Preview] Allow all story pages and grid layers to be rendered in preview mode #38030
Conversation
…en the attachment's owner has been set to itself
Hey @gmajoulet, @newmuis! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you host demos for these PRs so I can help you with manual testing as well? Code LGTM : ))
Warning: disparity between this PR Percy build and its The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build /
|
PREVIEW
visibility state #37129previewAllowed()
was defaulting toprerenderAllowed()
behavior for story pages and grid layers, but this behavior only allows the first story page and its grid layers to be rendered. In preview mode, all pages and grid layers must be rendered so that they can be seen in the SERP while the story auto-advances.