Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Amp story captions] Render video captions with amp-story-captions when in an amp-story doc and served from cache #37899

Closed
processprocess opened this issue Mar 18, 2022 · 3 comments · Fixed by #38108
Closed

[Amp story captions] Render video captions with amp-story-captions when in an amp-story doc and served from cache #37899

processprocess opened this issue Mar 18, 2022 · 3 comments · Fixed by #38108
Assignees
@processprocess
Labels
P1: High Priority Type: Feature Request WG: stories

Comments

@processprocess
Copy link
Contributor

processprocess commented Mar 18, 2022 •
edited
Loading

Description

video captions should render with the amp-story-captions component when provided from cache and in an amp-story.

By default they will:

Captions design doc
@processprocess processprocess self-assigned this Mar 18, 2022
@processprocess processprocess mentioned this issue Mar 18, 2022
Closed
@processprocess processprocess changed the title [Video captions] Render video captions with amp-story-captions when in an amp-story doc [Amp story captions] Render video captions with amp-story-captions when in an amp-story doc Mar 18, 2022
@processprocess processprocess mentioned this issue Mar 25, 2022
Closed
@swissspidy
Copy link
Contributor

Does that mean one would not have to manually include <amp-story-captions> anymore?

@processprocess
Copy link
Contributor Author

processprocess commented Apr 7, 2022 •
edited
Loading

Does that mean one would not have to manually include <amp-story-captions> anymore?

The script wouldn't need to be imported in head.

The amp-story-captions element would be a child of amp-video by default.
The publisher can still define it manually as a child of amp-story-page if they want it elsewhere in the document.

This was referenced Apr 15, 2022
Closed
Merged
@processprocess processprocess changed the title [Amp story captions] Render video captions with amp-story-captions when in an amp-story doc [Amp story captions] Render video captions with amp-story-captions when in an amp-story doc and served from cache Apr 21, 2022
@processprocess
Copy link
Contributor Author

Does that mean one would not have to manually include <amp-story-captions> anymore?

@swissspidy The scope of this work is only for captions provided from cache.
One will need to manually include <amp-story-captions> when using them inline.
Just wanted to update you on this!

@jshamble jshamble mentioned this issue May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@processprocess processprocess

Labels
P1: High Priority Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
2 participants
@swissspidy @processprocess