Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-story-player] Audit public API methods for layout state #34375

Open
Enriqe opened this issue May 13, 2021 · 1 comment
Open

[amp-story-player] Audit public API methods for layout state #34375

Enriqe opened this issue May 13, 2021 · 1 comment
Assignees
Labels
Stale Inactive for one year or more Type: Bug WG: stories

Comments

@Enriqe
Copy link
Contributor

Enriqe commented May 13, 2021

We should audit the public methods of the player for layout state.

In #34360, I found that by calling play() under certain circumstances (player hidden, and no user scroll), the player can break. We should investigate other public methods to see if they will work correctly (e.g. show(), add(), etc..).

/cc @ampproject/wg-stories

@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more Type: Bug WG: stories
Projects
None yet
Development

No branches or pull requests

2 participants