Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: failed to build: amp-experiment#1 Experiment amp-experiment-1.0 is not enabled. #29152

Closed
ampprojectbot opened this issue Jul 6, 2020 · 4 comments · Fixed by #29417
Labels
Type: Error Report An error reported by AMP Error Reporting WG: analytics

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Jun 19, 2019
Frequency: ~ 1,108/day

Stacktrace

Error: failed to build: amp-experiment#1 Experiment amp-experiment-1.0 is not enabled.
    at message (src/log.js:710:22)
    at src/log.js:316:8
    at src/log.js:330:36
    at TAG (src/service/resource.js:32:12)
    at reason (src/service/resource.js:351:44)

Notes

@dvoytenko modified src/log.js:709-723 in #2597 (Mar 15, 2016)
@rsimha modified src/log.js:315-318 in #21212 (May 16, 2019)
@erwinmombay modified src/log.js:330-331 in #6581 (Dec 20, 2016)
@dvoytenko modified src/service/resource.js:31-74 in #3544 (Jun 14, 2016)
@rsimha modified src/service/resource.js:351-354 in #21212 (May 16, 2019)

Seen in:

  • 06-11 Control (2352+3)
  • 06-11 Nightly-Control (2352+3)
  • 06-11 Stable (2352+3)
  • 06-18 Experiment-B (0239+2)
  • 06-18 Experimental (0239+2)
  • +2 more

/cc @ampproject/release-on-duty

@ampprojectbot ampprojectbot added the Type: Error Report An error reported by AMP Error Reporting label Jul 6, 2020
@dreamofabear
Copy link

@ampproject/wg-analytics Seems like a lot of errors for an unreleased extension. Did an origin trial expire?

@zhouyx
Copy link
Contributor

zhouyx commented Jul 21, 2020

Agreed could be an origin trial expiration. Is this reported as user errors?

@dreamofabear
Copy link

No, it's thrown from buildCallback. We probably just need to add a separate .catch() for the origin trial check.

@zhouyx
Copy link
Contributor

zhouyx commented Jul 21, 2020

I see. https://github.com/ampproject/amphtml/blob/master/extensions/amp-experiment/1.0/amp-experiment.js#L80

An easier way is to return early without throwing an error. I'll create a quick fix, we can safely ignore this error in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Error Report An error reported by AMP Error Reporting WG: analytics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants