We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error report: link First seen: Jun 19, 2019 Frequency: ~ 1,108/day
Error: failed to build: amp-experiment#1 Experiment amp-experiment-1.0 is not enabled. at message (src/log.js:710:22) at src/log.js:316:8 at src/log.js:330:36 at TAG (src/service/resource.js:32:12) at reason (src/service/resource.js:351:44)
@dvoytenko modified src/log.js:709-723 in #2597 (Mar 15, 2016) @rsimha modified src/log.js:315-318 in #21212 (May 16, 2019) @erwinmombay modified src/log.js:330-331 in #6581 (Dec 20, 2016) @dvoytenko modified src/service/resource.js:31-74 in #3544 (Jun 14, 2016) @rsimha modified src/service/resource.js:351-354 in #21212 (May 16, 2019)
@dvoytenko
src/log.js:709-723
@rsimha
src/log.js:315-318
@erwinmombay
src/log.js:330-331
src/service/resource.js:31-74
src/service/resource.js:351-354
Seen in:
/cc @ampproject/release-on-duty
The text was updated successfully, but these errors were encountered:
@ampproject/wg-analytics Seems like a lot of errors for an unreleased extension. Did an origin trial expire?
Sorry, something went wrong.
Agreed could be an origin trial expiration. Is this reported as user errors?
No, it's thrown from buildCallback. We probably just need to add a separate .catch() for the origin trial check.
buildCallback
.catch()
I see. https://github.com/ampproject/amphtml/blob/master/extensions/amp-experiment/1.0/amp-experiment.js#L80
An easier way is to return early without throwing an error. I'll create a quick fix, we can safely ignore this error in the meantime.
Successfully merging a pull request may close this issue.
Details
Error report: link
First seen: Jun 19, 2019
Frequency: ~ 1,108/day
Stacktrace
Notes
@dvoytenko
modifiedsrc/log.js:709-723
in #2597 (Mar 15, 2016)@rsimha
modifiedsrc/log.js:315-318
in #21212 (May 16, 2019)@erwinmombay
modifiedsrc/log.js:330-331
in #6581 (Dec 20, 2016)@dvoytenko
modifiedsrc/service/resource.js:31-74
in #3544 (Jun 14, 2016)@rsimha
modifiedsrc/service/resource.js:351-354
in #21212 (May 16, 2019)Seen in:
/cc @ampproject/release-on-duty
The text was updated successfully, but these errors were encountered: