Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amp-story-player available as an npm package #27615

Open
Enriqe opened this issue Apr 7, 2020 · 6 comments
Open

Make amp-story-player available as an npm package #27615

Enriqe opened this issue Apr 7, 2020 · 6 comments
Assignees
Labels

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Apr 7, 2020

We should consider making the amp-story-player(tracker: #26308) available as an npm package. This will make it easier for people using frameworks like React to install it using npm install.

This might require pulling it into a separate repository.

/cc @kristoferbaxter
/cc @ampproject/wg-stories

@Enriqe Enriqe self-assigned this Apr 7, 2020
@kristoferbaxter
Copy link
Contributor

Thanks for filling this issue, when you're ready to address we can create a plan based on the other modules we're already publishing in both forms.

@gmajoulet
Copy link
Contributor

@kristoferbaxter do you have guidance on how to proceed here?

@gmajoulet
Copy link
Contributor

friendly ping @kristoferbaxter

@kristoferbaxter
Copy link
Contributor

Oh, sorry for the delay.

Yes, the likely best path is to create a separate repo for now and sync the version with amphtml if necessary. Happy to discuss over a VC and show how this is done for other items in the @ampproject scope.

@kristoferbaxter
Copy link
Contributor

Notes (as I recall them) from meeting:

  1. We'd like to publish a new version (semver minor) with each weekly release of amphtml.
  2. Publish a new @beta version with each nightly release of amphtml.
  3. Can be a manual process at first.
  4. Prefer automated approach with secure pipeline longterm.

@Enriqe Enriqe assigned gmajoulet and unassigned Enriqe Jun 8, 2021
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants