You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In amp-auto-lightbox, the this.element does not have a type declaration. The use of this.element is therefore not checked against available methods by type checker. Any method in the entire codebase having the same method name would satisfy the type checker.
In case of a refactoring where the method is moved from a class to another, the type checker will pass.
We could look at whether we should generate warning or block the PR when insufficient information is provided (especially in extensions) for the type checker to properly do its jobs.
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
#26483
In
amp-auto-lightbox
, thethis.element
does not have a type declaration. The use ofthis.element
is therefore not checked against available methods by type checker. Any method in the entire codebase having the same method name would satisfy the type checker.In case of a refactoring where the method is moved from a class to another, the type checker will pass.
We could look at whether we should generate warning or block the PR when insufficient information is provided (especially in extensions) for the type checker to properly do its jobs.
The text was updated successfully, but these errors were encountered: