Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checker does not warn when no type inference can be made #26750

Open
powerivq opened this issue Feb 12, 2020 · 3 comments
Open

Type checker does not warn when no type inference can be made #26750

powerivq opened this issue Feb 12, 2020 · 3 comments
Assignees
Labels
Stale Inactive for one year or more Type: Bug WG: infra

Comments

@powerivq
Copy link
Contributor

#26483

In amp-auto-lightbox, the this.element does not have a type declaration. The use of this.element is therefore not checked against available methods by type checker. Any method in the entire codebase having the same method name would satisfy the type checker.

In case of a refactoring where the method is moved from a class to another, the type checker will pass.

We could look at whether we should generate warning or block the PR when insufficient information is provided (especially in extensions) for the type checker to properly do its jobs.

@dreamofabear
Copy link

Relevant: #13791

@rsimha
Copy link
Contributor

rsimha commented Apr 22, 2021

[Infra triage] @samouri Is this something that can be fixed as part the changes you're making to AMP's type-checker?

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more Type: Bug WG: infra
Projects
None yet
Development

No branches or pull requests

4 participants