🌸 Cherry-pick request for #25007 into #25319 (Approved) #25367
Labels
Cherry-pick: Beta
Cherry-pick: Experimental
Type: Release
Used to track AMP releases from canary to production
Cherry-pick request
Why does this issue meet the cherry-pick criteria?
The fixes unbreak a4a ads in shadow mode, which has significant impact.
Mini-postmortem
The reason for this bug is an incorrect use of the top level
window.document
API which has different meaning in shadow docs, FIE, scoped services, etc.Summary
We received the report in #25007 that A4A ads would not render at all into PWA shell. This is a regression, but is unclear when exactly it started. The issue got attention from representatives from multiple companies, indicating it was a problem breaking all users of PWA model.
Root Causes
window.document
API instead of ampdoc.Action Items
window.document
APILessons Learned
Things that went well
Things that went wrong
/cc @ampproject/wg-approvers @ampproject/cherry-pick-approvers
/cc @calebcordry @jeffjose
The text was updated successfully, but these errors were encountered: