Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-auto-lightbox.js unexpectedly loaded on image-less page #25137

Closed
ithinkihaveacat opened this issue Oct 18, 2019 · 2 comments
Closed

amp-auto-lightbox.js unexpectedly loaded on image-less page #25137

ithinkihaveacat opened this issue Oct 18, 2019 · 2 comments

Comments

@ithinkihaveacat
Copy link
Contributor

ithinkihaveacat commented Oct 18, 2019

The amp-auto-lightbox.js file is unexpectedly loaded from pages that do not directly reference it (or use any images).

To reproduce:

  1. Load https://separated-mollusk.glitch.me in Chrome Desktop (also reproduces on Firefox)
  2. Open devtools network tab and reload.

Actual:

Three resources are loaded: the HTML (expected), v0.js (expected) and amp-auto-lightbox-0.1.js (unexpected).

Screenshot 2019-10-18 at 20 47 57

Expected:

Only two resources are loaded.

@photocoder
Copy link

You can use "data-amp-auto-lightbox-disable" option... But I'm waiting for opt-out possibility by this option: doc level opt-out of amp-auto-lightbox

@alanorozco
Copy link
Member

Yup, loads for every page. Closing as dupe of #26452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants