Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "google|gmail" from trustedViewerHosts in config.js #25040

Open
dreamofabear opened this issue Oct 14, 2019 · 4 comments
Open

Remove "google|gmail" from trustedViewerHosts in config.js #25040

dreamofabear opened this issue Oct 14, 2019 · 4 comments
Assignees
Labels
Stale Inactive for one year or more Type: Feature Request WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required.

Comments

@dreamofabear
Copy link

Context: #25027 (comment)

@dreamofabear
Copy link
Author

@mrjoro FYI this helps decouple "google" from our source code.

@ampproject/wg-infra Is this related to any planned OpenJS migration work?

@rsimha
Copy link
Contributor

rsimha commented Dec 9, 2019

Yes, this will be included in the list of tasks for the Open JS migration. There's a tracking issue at https://github.com/ampproject/wg-infra/issues/18 with a larger discussion that includes folks from @ampproject/wg-caching.

@Gregable Gregable added the WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required. label Feb 11, 2020
@rsimha rsimha removed the WG: infra label Apr 22, 2021
@rsimha
Copy link
Contributor

rsimha commented Apr 22, 2021

[Infra triage] Since this issue was filed two years ago, the OpenJS migration was completed. See ampproject/wg-caching#13 (comment) for more details.

However, the offending lines are still in our codebase.

amphtml/src/config.js

Lines 97 to 112 in e5c57a6

/**
* These domains are trusted with more sensitive viewer operations such as
* propagating the referrer. If you believe your domain should be here,
* file the issue on GitHub to discuss. The process will be similar
* (but somewhat more stringent) to the one described in the [3p/README.md](
* https://github.com/ampproject/amphtml/blob/main/3p/README.md)
*
* {!Array<!RegExp>}
*/
trustedViewerHosts: [
/(^|\.)google\.(com?|[a-z]{2}|com?\.[a-z]{2}|cat)$/,
/(^|\.)gmail\.(com|dev)$/,
],
// Optional fallback API if amp-geo is left unpatched
geoApi: env['geoApiUrl'] || getMetaUrl('amp-geo-api'),
};

Assigning to @jridgewell for comment on if / how they can be removed from AMP. If they must stay, this issue can be closed.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more Type: Feature Request WG: Caching: Triaged Initial triage from wg-caching complete. Remove label if new input required.
Projects
None yet
Development

No branches or pull requests

4 participants