-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "google|gmail" from trustedViewerHosts in config.js #25040
Comments
@mrjoro FYI this helps decouple "google" from our source code. @ampproject/wg-infra Is this related to any planned OpenJS migration work? |
Yes, this will be included in the list of tasks for the Open JS migration. There's a tracking issue at https://github.com/ampproject/wg-infra/issues/18 with a larger discussion that includes folks from @ampproject/wg-caching. |
[Infra triage] Since this issue was filed two years ago, the OpenJS migration was completed. See ampproject/wg-caching#13 (comment) for more details. However, the offending lines are still in our codebase. Lines 97 to 112 in e5c57a6
Assigning to @jridgewell for comment on if / how they can be removed from AMP. If they must stay, this issue can be closed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Context: #25027 (comment)
The text was updated successfully, but these errors were encountered: