Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator does not recognize data-amp-bind-src for amp-list #24710

Closed
sebastianbenz opened this issue Sep 24, 2019 · 2 comments
Closed

Validator does not recognize data-amp-bind-src for amp-list #24710

sebastianbenz opened this issue Sep 24, 2019 · 2 comments
Assignees

Comments

@sebastianbenz
Copy link
Contributor

sebastianbenz commented Sep 24, 2019

This fails validation:

<amp-list layout="fixed-height" height="100" data-amp-bind-src="https://preview.amp.dev/static/samples/json/examples.json" binding="no">
    <template type="amp-mustache">
      <div><a href="{{url}}">{{title}}</a></div>
    </template>
  </amp-list>

with: The tag 'amp-list' is missing a mandatory attribute - pick at least one of ['src','[src]'].

Even though the following is valid AMP:

<amp-list layout="fixed-height" height="100" [src]="https://preview.amp.dev/static/samples/json/examples.json" binding="no">
    <template type="amp-mustache">
      <div><a href="{{url}}">{{title}}</a></div>
    </template>
  </amp-list>
@sebastianbenz sebastianbenz changed the title Validation data-amp-bind-src Validator does not recognize data-amp-bind-src for amp-list Sep 24, 2019
@Gregable
Copy link
Member

This looks like a dupe of #24661 would you agree?

@sebastianbenz
Copy link
Contributor Author

sebastianbenz commented Sep 24, 2019

LOL - yes. I read the bug before (and even assigned you). Then forgot about it and ran into the same problem in a different context 🤦‍♂️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants