Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MASTER FEATURE] auto lightbox <amp-img> #20236

Closed
nainar opened this issue Jan 9, 2019 · 2 comments
Closed

[MASTER FEATURE] auto lightbox <amp-img> #20236

nainar opened this issue Jan 9, 2019 · 2 comments
Assignees
@alanorozco
Labels
Type: Feature Request WG: components
Milestone
New FRs

Comments

@nainar
Copy link
Contributor

nainar commented Jan 9, 2019

Currently developers can mark an <amp-img> to be lightboxed by adding the lightbox attribute to it.

We should be able to (following some heuristic) auto-lightbox some images in a page. For e.g. all images in an article, images in a recipe.

cc @ampproject/wg-ui
@aghassemi aghassemi mentioned this issue Jan 9, 2019
Closed
11 tasks
@aghassemi aghassemi mentioned this issue Jan 17, 2019
Closed
@aghassemi aghassemi mentioned this issue Jan 19, 2019
Closed
@ampprojectbot ampprojectbot added this to the New FRs milestone Jan 24, 2019
@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @alanorozco Please add an appropriate category.

@aghassemi aghassemi mentioned this issue Feb 2, 2019
Closed
@aghassemi
Copy link
Contributor

Implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanorozco alanorozco

Labels
Type: Feature Request WG: components
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
4 participants
@alanorozco @aghassemi @nainar @ampprojectbot