Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just how does the viewer work? #1686

Closed
jpettitt opened this issue Jan 30, 2016 · 2 comments
Closed

Just how does the viewer work? #1686

jpettitt opened this issue Jan 30, 2016 · 2 comments

Comments

@jpettitt
Copy link
Contributor

I've been looking at the viewer example code all day and come to the conclusion that it will never actually work. Specifically the viewer example has a lot of message passing code in viewer-integr-messaging.js but if I grep the source and look at every addEventListener() call in the ./src tree I can only find one instance where it's listening for 'message' and that is in listen() in iframe-helper.js which isn't being called if there are no <amp-iframe> elements.

I confirmed this in chrome debugger by dumping all the listeners on the iframe window containing the AMP document and there is nothing there listening for messages.

What am I missing?

@dvoytenko
Copy link
Contributor

Viewer is not enabled quite yet and the protocol has not been standardized. We are working on it.

@jpettitt
Copy link
Contributor Author

That explains a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants