Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data: URI support to amp-img #1642

Closed
kevinmarks opened this issue Jan 28, 2016 · 2 comments
Closed

Add data: URI support to amp-img #1642

kevinmarks opened this issue Jan 28, 2016 · 2 comments

Comments

@kevinmarks
Copy link

https://withknown.com creates AMP versions of pages and links to them. However, if an image is in a data: URI, amp doesn't render it.

AMP version:

http://known.kevinmarks.com/2016/translating-what-you-write-to-other-sites?_t=amp

normal version:

http://known.kevinmarks.com/2016/translating-what-you-write-to-other-sites

@dvoytenko
Copy link
Contributor

@kevinmarks I took a look. I think the problem is not a data URL, but that the image does not have a layout. I added layout attributes and it appears to show:

<amp-img layout=responsive width=400 height=300
                                   class="ui-sortable-handle">
...

See http://jsbin.com/cihalu/edit?html,output

@dvoytenko
Copy link
Contributor

I'll close for now, but please reopen if something is outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants