Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization of custom elements in friendly iframe causes error to be logged. #16416

Closed
cramforce opened this issue Jun 27, 2018 · 3 comments
Closed

Comments

@cramforce
Copy link
Member

cramforce commented Jun 27, 2018

This repros on any page with an A4A ad that contains at least one custom element.
screen shot 2018-06-27 at 8 40 54 am

v0.js:42 Uncaught TypeError: Cannot read property 'create' of undefined
    at new uj (v0.js:42)
    at new Cf (document-register-element.node.js:294)
    at document-register-element.node.js:284
    at Wb (document-register-element.node.js:291)
    at Sl (amp-img.js:152)
    at Kl.f.installExtensionsInChildWindow (vsync-impl.js:438)
    at friendly-iframe-embed.js:209

Example URL https://amp-20minutos-es.cdn.ampproject.org/v/s/amp.20minutos.es/noticia/3357093/0/nueva-portada-revista-time-creada-98-drones/?amp_js_v=0.1&usqp=mq331AQECAEoAQ%3D%3D

This appears to be harmless but spams the console. I don't completely follow why it is logged OR why it is harmless :)

@oliverfernandez
Copy link
Contributor

This is happening in AMP Shadows as well, whenever an AMP-AD with Doubleclick Fast Fetch implementation is used

screen shot 2018-06-29 at 17 10 50

https://www.thelondoneconomic.com/

We have detected this since 2 weeks ago approximately

@gabelew
Copy link

gabelew commented Aug 16, 2018

We are getting the same error as we also have amp-img in our ad. Is there any update to this issue?

@jridgewell
Copy link
Contributor

This will be fixed by #17205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants