Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator for "heights" rules #1616

Closed
dvoytenko opened this issue Jan 27, 2016 · 3 comments
Closed

Validator for "heights" rules #1616

dvoytenko opened this issue Jan 27, 2016 · 3 comments
Assignees

Comments

@dvoytenko
Copy link
Contributor

The new "heights" attribute is part of the layout=responsive ecosystem. It's developed in #1331

The rules are very similar to sizes attribute:

  1. If layout is not specified and heights attribute is specified - implied layout is responsive
  2. heights attribute can only be specified for elements with layout=responsive - input or implied
  3. The format of the heights attribute is the same as sizes with a single exception that % are allowed as values (not sure we actually validate content of sizes attribute).
@rudygalfi
Copy link
Contributor

@powdercloud Is this all done?

/cc @dvoytenko

@Gregable
Copy link
Member

Gregable commented Feb 4, 2016

Not quite. It's available in the javascript messages, but has not rolled out to search carousel selection yet.

@rudygalfi rudygalfi modified the milestones: M1, Up Next Mar 4, 2016
@powdercloud
Copy link
Contributor

At this point quite sure it's out everywhere, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants