Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Flaky tests in test-resources.js #16021

Closed
calebcordry opened this issue Jun 13, 2018 · 6 comments
Closed

🐛Flaky tests in test-resources.js #16021

calebcordry opened this issue Jun 13, 2018 · 6 comments

Comments

@calebcordry
Copy link
Member

Several tests in this file are flaking with no immediately obvious pattern.

Some examples:
https://travis-ci.org/ampproject/amphtml/jobs/391329023 (this is the most frequent)
https://travis-ci.org/ampproject/amphtml/jobs/391379325
https://travis-ci.org/ampproject/amphtml/jobs/391742459

@calebcordry
Copy link
Member Author

cc/ @rsimha

@calebcordry
Copy link
Member Author

I thought this was the same as the first link, but it is actually slightly different:
https://travis-ci.org/ampproject/amphtml/jobs/391544247

@dreamofabear
Copy link

DESCRIBE => Resources discoverWork
  IT => "after each" hook for "should update inViewport before scheduling layouts"
    ✗ Unexpected call: getRect() at setState@/tmp/src/finite-state-machine.js:73:6 <- /tmp/5c710cc6478d2b0f6baf816fd1c218c5.browserify:66544:15
    Unexpected call: getRect() at setState@/tmp/src/finite-state-machine.js:73:6 <- /tmp/5c710cc6478d2b0f6baf816fd1c218c5.browserify:66544:15
    Unexpected call: getRect() at setState@/tmp/src/finite-state-machine.js:73:6 <- /tmp/5c710cc6478d2b0f6baf816fd1c218c5.browserify:66544:15

DESCRIBE => Resources changeSize
  DESCRIBE => attemptChangeSize rules wrt viewport
    IT => should change size when document is invisible
      ✗ Attempted to wrap getVisibilityState which is already wrapped

  IT => "after each" hook for "should change size when document is invisible"
    ✗ Expected getRect([...]) at least once (never called)

IT => "after each" hook for "should change size when document is invisible"
  ✗ You likely forgot to restore sinon timers (installed via sandbox.useFakeTimers).

[16:10:03] Safari 11.1.0 (Mac OS X 10.13.4): Executed 1750 of 3595 (Skipped 174) 4 FAILED

I think this started getting more flaky on Safari 11.1.

@dreamofabear
Copy link

/cc @jridgewell

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @jridgewell Do you have any updates?

@dreamofabear
Copy link

Closing as dupe of #16124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants