Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier way to preview AMP components within editors #15241

Closed
newmuis opened this issue May 11, 2018 · 4 comments
Closed

Easier way to preview AMP components within editors #15241

newmuis opened this issue May 11, 2018 · 4 comments
Assignees
@sirjonathan
Labels
Type: Feature Request

Comments

@newmuis
Copy link
Contributor

newmuis commented May 11, 2018

When using AMP components in WYSIWYG editors, it can be difficult to preview AMP components and update them live, e.g. with React. We should provide an easier way to do this.
@newmuis
Copy link
Contributor Author

newmuis commented May 11, 2018

I have noticed this when experimenting with amp-story in such a context; the only easy way to do it is to put the story in the srcdoc of an iframe and update that on every change; this only works because <amp-story> is the entirety of the document.

@newmuis
Copy link
Contributor Author

newmuis commented May 11, 2018

/to @sirjonathan to add some context around his experiences

@newmuis
Copy link
Contributor Author

newmuis commented May 24, 2018

ping @sirjonathan, if you have a moment to comment on the difficulties you were having embedding AMP components.

@newmuis
Copy link
Contributor Author

newmuis commented May 25, 2018

Duplicate of #15583.

@newmuis newmuis closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirjonathan sirjonathan

Labels
Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirjonathan @newmuis