Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-img: Support both native (viewport based) and container-based srcset selection #13178

Closed
aghassemi opened this issue Jan 31, 2018 · 1 comment

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Jan 31, 2018

The container-based srcset selection is useful for use-cases such as thumbnail grids and since everything in AMP has a known layout-size and images are lazy loaded, we have a unique opportunity to support this whereas the web platform can not without sacrificing early prefetching of images.

Please note that we may not always honour container-based srcset and may default back to native for certain images above the fold where we want to prefetch event before AMP runtime calculates the layout.

Suggestion is to make this opt-in on amp-img

1- srcset-selection=<native|optimized> (defaults to native)
2- srcset-selection=<native|container> (defaults to native)
3- ???

Related issue: #11575

@aghassemi
Copy link
Contributor Author

Closing, based on the Design Review linked above, decision was just to polyfil sizes instead which will be done as part of #11575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant