You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To handle the use case of having small thumbnails show a high resolution image in lightbox gallery, we should try to upgrade the srcset / update sizes after opening the image in lightbox gallery. Some experimentation can be done with changing the sizes attribute and seeing whether browsers are able to handle this natively. Otherwise, we can revisit the logic to parse and find the correct src using srcset and upgrade on zoom. Blocked by #11575.
This issue hasn't been updated in awhile. @cathyxz Do you have any updates?
cathyxz
changed the title
Lightbox: handle srcsets properly in zoom
[amp-lightbox-gallery] upgrade srcset on open or zoom to handle thumbnail usecase
Jul 2, 2018
To handle the use case of having small thumbnails show a high resolution image in lightbox gallery, we should try to upgrade the srcset / update sizes after opening the image in lightbox gallery. Some experimentation can be done with changing the sizes attribute and seeing whether browsers are able to handle this natively. Otherwise, we can revisit the logic to parse and find the correct
src
usingsrcset
and upgrade on zoom. Blocked by #11575.Here's a test case: https://codepen.io/cathyxz/full/rreWev/
The text was updated successfully, but these errors were encountered: