From 07ce92d203e7b03bf087035613a30a22cf0149c3 Mon Sep 17 00:00:00 2001 From: Jacek Drobiecki Date: Thu, 28 May 2020 17:41:47 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20amp-ad=20adocean:=20remove?= =?UTF-8?q?=20unnecessary=20preview=20ID=20#1=20(#28443)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [ADOCEAN-20673] remove livepreview1 * fix lint error --- ads/adocean.js | 2 -- ads/adocean.md | 4 ++-- examples/ads.amp.esm.html | 8 ++++---- examples/ads.amp.html | 8 ++++---- 4 files changed, 10 insertions(+), 12 deletions(-) diff --git a/ads/adocean.js b/ads/adocean.js index bee294ab084a..7b3e87071952 100644 --- a/ads/adocean.js +++ b/ads/adocean.js @@ -62,8 +62,6 @@ function setupPreview(global, data) { if (global.ado && data.aoPreview && !isFalseString(data.aoPreview)) { global.ado.preview({ enabled: true, - emiter: data['aoEmitter'], - id: data['aoPreview'], }); } } diff --git a/ads/adocean.md b/ads/adocean.md index 7c2ea4ea4145..e640cc0b3a40 100644 --- a/ads/adocean.md +++ b/ads/adocean.md @@ -74,10 +74,10 @@ For details on the configuration semantics, see [AdOcean documentation](http://w ### Optional parameters - `data-ao-mode` - sync|buffered - processing mode -- `data-ao-preview` - livepreview configuration id +- `data-ao-preview` - true|false - whether livepreview is enabled - `data-ao-keys` - additional configuration, see adserver documentation, do not define different values for slaves within one master - `data-ao-vars` - additional configuration, see adserver documentation, do not define different values for slaves within one master -- `data-ao-clusters` - additional configuration,see adserver documentation +- `data-ao-clusters` - additional configuration, see adserver documentation - `data-ao-master` - unique id of master placement ## User Consent Integration diff --git a/examples/ads.amp.esm.html b/examples/ads.amp.esm.html index d4e85efe0da8..2dce521a227c 100644 --- a/examples/ads.amp.esm.html +++ b/examples/ads.amp.esm.html @@ -523,7 +523,7 @@

AdOcean

data-ao-mode="sync" data-ao-emitter="myao.adocean.pl" data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -535,7 +535,7 @@

AdOcean

data-ao-mode="buffered" data-ao-emitter="myao.adocean.pl" data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -549,7 +549,7 @@

AdOcean master-slave

data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7" data-ao-id="adoceanmyaonhqnqukjtt" data-ao-mode="buffered" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -562,7 +562,7 @@

AdOcean master-slave

data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7" data-ao-id="adoceanmyaokiheeseoko" data-ao-mode="buffered" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' diff --git a/examples/ads.amp.html b/examples/ads.amp.html index a259e503e136..701f66212861 100644 --- a/examples/ads.amp.html +++ b/examples/ads.amp.html @@ -528,7 +528,7 @@

AdOcean

data-ao-mode="sync" data-ao-emitter="myao.adocean.pl" data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -540,7 +540,7 @@

AdOcean

data-ao-mode="buffered" data-ao-emitter="myao.adocean.pl" data-ao-id="ado-vf2X22YCNzPRUVYmLg.jQb53Xb1BcMbzJlwIv7SLH_f.97" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -554,7 +554,7 @@

AdOcean master-slave

data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7" data-ao-id="adoceanmyaonhqnqukjtt" data-ao-mode="buffered" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}' @@ -567,7 +567,7 @@

AdOcean master-slave

data-ao-master="FDyQKk0qN2a9SxwCMal6Eove..r_lvBE3pPfr_Ier9..f7" data-ao-id="adoceanmyaokiheeseoko" data-ao-mode="buffered" - data-ao-preview="y6g3tTbLJv6vLRZ.AfyeiXkCPM0gL3CNAik2rwTzhKD.N7" + data-ao-preview="true" data-ao-keys="key1,key2,key3" data-ao-vars='{"a":"b","c":"d"}' data-ao-clusters='{"clusterA":[-1,2,-3,63], "clusterB":[1,-63]}'