Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amp-story-audio-sticker to spec #7603

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Aug 31, 2023

Summary

See ampproject/amphtml@d1301d7

See ampproject/amp-toolbox-php#542

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

Plugin builds for 467949b are ready 🛎️!

@westonruter westonruter added this to the v2.4.3 milestone Aug 31, 2023
@westonruter
Copy link
Member

It doesn't look like the validator changes have yet made it to production:

Screenshot 2023-08-31 08 52 49

So probably need to hold off on a Web Stories plugin release that uses these until the validator has been updated.

@westonruter westonruter merged commit b16d220 into develop Aug 31, 2023
35 of 37 checks passed
@westonruter westonruter deleted the add/amp-story-audio-sticker branch August 31, 2023 15:55
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants