Remove WP_DEBUG from local-env till WP 6.3 is released #7591
Conversation
thelovekesh
force-pushed
the
fix/failing-e2e-tests
branch
from
f0f1282 to
419f8e5
Compare
|
Plugin builds for a9338e1 are ready 🛎️!
|
thelovekesh
force-pushed
the
fix/failing-e2e-tests
branch
4 times, most recently
from
8147a67 to
d001e7b
Compare
thelovekesh
force-pushed
the
fix/failing-e2e-tests
branch
from
691a3fd to
bb6cf33
Compare
| /* | ||
| * Disable interactivity API on core/navigation block. | ||
| * Currently this support is added by Gutenberg plugin, but it will be a part of WP 6.3 as well. | ||
| * | ||
| * @TODO: Need to revisit once Interactivity API is landed in WP Core. | ||
| */ | ||
| add_filter( 'gutenberg_should_block_use_interactivity_api', '__return_false' ); |
There was a problem hiding this comment.
If this is added here, then the inverse should be done in unregister_embed.
Nevertheless, the gutenberg_should_block_use_interactivity_api filter passes a second argument which is the block name. Should this be checked to only disable the Navigation block?
There was a problem hiding this comment.
Nevertheless, the gutenberg_should_block_use_interactivity_api filter passes a second argument which is the block name. Should this be checked to only disable the Navigation block?
Do we need interactivity API enabled on any block in our case? Since this API will be added in more blocks and those modifications could be problematic, I believe we should keep it disabled for all blocks.
|
|
||
| # @TODO: Remove it once Gutnberg 16.3 is released. | ||
| # wp plugin install gutenberg --activate --force --quiet | ||
| wp plugin activate gutenberg --quiet |
There was a problem hiding this comment.
While not critical since this is temporary, the wp plugin install command also allows you to pass a URL to a ZIP file. So this could have been done instead of modifying start.sh:
| # @TODO: Remove it once Gutnberg 16.3 is released. | |
| # wp plugin install gutenberg --activate --force --quiet | |
| wp plugin activate gutenberg --quiet | |
| # @TODO: Remove it once Gutnberg 16.3 is released. | |
| # wp plugin install gutenberg --activate --force --quiet | |
| wp plugin install https://amp-wp.org/wp-content/uploads/2023/07/gutenberg.zip --activate --force --quiet |
There was a problem hiding this comment.
I tried it but it was adding a suffix in the plugin name something like gutenberg-Ad5fe and it was problematic.
westonruter
added
the
Changelogged
Summary
Fix failing E2E tests after Gutenberg 16.2.1 release.
Checklist