Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow themes to register support for AMP canonical mode #848

Closed
2 tasks done
ThierryA opened this issue Jan 9, 2018 · 1 comment
Closed
2 tasks done

Allow themes to register support for AMP canonical mode #848

ThierryA opened this issue Jan 9, 2018 · 1 comment
Assignees
@kienstra
Milestone
v0.7

Comments

@ThierryA
Copy link
Collaborator

ThierryA commented Jan 9, 2018 •
edited by kienstra
Loading

Acceptance Criteria

AC1: Allow themes to register support for AMP canonical with add_theme_support( 'amp' ) (As @westonruter’s comment proposed).
AC2: If support is added, this would remove paired mode. The site would only serve AMP, and there wouldn’t be /amp or ?amp URLs.

Tasks

  • Check if AMP theme support exists, and if so, do not activate the current AMP templating system and the current paired mode.
  • When AMP theme support is present, prevent AMP rel link in head and other frontend actions that assume paired mode.
@ThierryA ThierryA added this to the v0.7 milestone Jan 9, 2018
@kienstra
Copy link
Contributor

In Development

Hi @ThierryA,
Thanks for these acceptance criteria. I'm working on this now.

@kienstra kienstra mentioned this issue Jan 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kienstra kienstra

Labels
None yet
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
2 participants
@ThierryA @kienstra