You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears that the amp_wp_build.py script hasn't been run since it was introduced at the end of 2016. Since that time, the changes to class-amp-allowed-tags-generated.php appear to have been done manually. There have been 95 commits to the spec since the end of 2016, and these changes need to be comprehensively added to the plugin.
I understand the amp_wp_build.py script has to be updated to account for some changes to the spec and to the amphtml project. For example, a dependency has been removed which has to be reverted or restored in some way: ampproject/amphtml#10830
Additionally, the spec changes need to be more regularly applied, such as via Travis CI cron, if not done manually.
The text was updated successfully, but these errors were encountered:
Conduct a Discovery to fully determine how the existing script is working.
Based on the findings of the Discovery, determine the best way to fix the components/functions of the script that are either broken or not working as intended.
More details to come post Discovery...
Additional acceptance criteria:
4. Create the new allowed tags file, class-amp-allowed-tags-generated.php
5. Open a pull request to the plugin repo with that new file, updated PHPUnit tests, and this commit to prevent an error in accessing an undefined property and update the extensions/paths 6. Submit a pull request to amphtml to revert the deletion of validator_gen_md.py, making this commit.
6. Create a bin/update-allowed-tags script that runs everything, including composer etc.
[Edited] Refer to the latest acceptance criteria.
It appears that the
amp_wp_build.py
script hasn't been run since it was introduced at the end of 2016. Since that time, the changes toclass-amp-allowed-tags-generated.php
appear to have been done manually. There have been 95 commits to thespec
since the end of 2016, and these changes need to be comprehensively added to the plugin.I understand the
amp_wp_build.py
script has to be updated to account for some changes to the spec and to the amphtml project. For example, a dependency has been removed which has to be reverted or restored in some way: ampproject/amphtml#10830Additionally, the spec changes need to be more regularly applied, such as via Travis CI cron, if not done manually.
The text was updated successfully, but these errors were encountered: