Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for no-JS styling and noscript > style[amp-noscript] #6603

Closed
westonruter opened this issue Sep 13, 2021 · 0 comments
Closed

Add support for no-JS styling and noscript > style[amp-noscript] #6603

westonruter opened this issue Sep 13, 2021 · 0 comments
Labels
CSS Enhancement New feature or improvement of an existing one

Comments

@westonruter
Copy link
Member

Feature description

In ampproject/amphtml#20609 AMP now allows a noscript > style[amp-noscript] to style elements on pages for which the user has JavaScript disabled. Currently the AMP plugin unwraps all noscript elements (unless they have a data-amp-no-unwrap attribute) so any nested style will then automatically be added to style[amp-custom]. However, when unwrapping has been disabled (per #6528 and #6546), any such styles should be moved not to style[amp-custom] but rather to noscript > style[amp-noscript].

See also ampproject/amp-toolbox-php#349.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Enhancement New feature or improvement of an existing one CSS labels Sep 13, 2021
@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
@westonruter westonruter reopened this Aug 30, 2022
@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Enhancement New feature or improvement of an existing one
Projects
None yet
Development

No branches or pull requests

1 participant