Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox settings are not honored when Gutenberg is active. #6485

Closed
milindmore22 opened this issue Jul 26, 2021 · 4 comments
Closed

Lightbox settings are not honored when Gutenberg is active. #6485

milindmore22 opened this issue Jul 26, 2021 · 4 comments
Labels

Comments

@milindmore22
Copy link
Collaborator

milindmore22 commented Jul 26, 2021

Bug Description

While debugging an issue for a user from support topic, I noticed that AMP Lightbox is forced on Images and Gallery even when the user has not opted-in for it.

The issue may be something similar to #5122

Expected Behaviour

Lightbox toggle settings should be honored images should not open in lightbox

Steps to reproduce

  1. Install and Activate the latest Gutenberg plugin
  2. Create a New post
  3. Add Image block ( do not opt-in for lightbox)
  4. Add Gallery Block (do not opt-in for lightbox )
  5. Save -> Visit Post -> AMP page
  6. Click on Image (Open up in Lightbox)
  7. Click on any image from Gallery (Opens up in Lightbox)

Screenshots

https://recordit.co/SdhDQ4ZegK

Additional context

  • WordPress version: 5.8
  • Plugin version: 2.1.3
  • Gutenberg plugin version (if applicable): 11.1.0
  • AMP plugin template mode: Transitional Mode
  • PHP version: 7.4
  • OS: Mac OS Catlina
  • Browser: [e.g. chrome, safari] Chrome
  • Device: [e.g. iPhone6] Macbook Air

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@milindmore22 milindmore22 added the Bug Something isn't working label Jul 26, 2021
@westonruter
Copy link
Member

@milindmore22 Please confirm if it is the same issue via #5122 (comment) to turn off auto-lightbox.

@milindmore22
Copy link
Collaborator Author

Yes, it's the same issue, but it was reproducible with the Gutenberg plugin and not with Core Block Editor.

@westonruter
Copy link
Member

I'm confused. The issue doesn't happen when Gutenberg is deactivated?

@milindmore22
Copy link
Collaborator Author

I am unable to reproduce the issue today, I think it may be the cached results that got me confused, sorry to take your time I will mark this issue as closed.

@westonruter westonruter added Invalid and removed Bug Something isn't working labels Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants