-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Stylesheets Box on Validated URL Screen #6441
Comments
@delawski in our last Leads meeting, Alberto asked if we could add a note that the % column is difficult for users to understand. There are some challenges with differentiating between 71% and 49%, for instance. Is this something we could put in numbers visually, or replace the bar with %? The bar itself isn't quite enough to convey what's happening. cc @amedina and @westonruter |
@jwold That's a good point. Yes, I think we can definitely add a number next to or above the bar, or replace the bar entirely with a number. If you have a suggestion on what would work better, please share. |
I'm thinking in this case we may want to replace the bar entirely just with percentages. Does that make sense? |
Yes, I think replacing the bar with percentage numbers makes sense, or a number overlaying the bar as I recall seeing Ken show a design mock for. Originally I was just trying to find a good use of |
This is ready for review but is parked. Building block piece not required to address for narrative. Not needed for 2.2, and needs further iterations in the future. Hence not being prioritized. |
Feature description
Following the strangler fig approach, the "Stylesheets" meta box on the Validated URL screen is a good first candidate to go through the redesign process (#2316).
Right now, it uses the regular WordPress functionality, i.e. list tables and admin hooks.
The aim of this issue is to replace the server-side rendered meta box with a React-based component fed via the REST API.
It will require the following to be done:
GET /wp-json/amp/v1/validated-urls/:id/
, that will return the validation data stored in aamp_validated_url
post type. For now, the response data structure will be limited to just thestylesheets
data structure (along with some general fields likeid
,url
,date
, etc.).Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: