Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Analytics admin menu item to link to jump to expanded Analytics drawer on settings screen #5190

Closed
westonruter opened this issue Aug 6, 2020 · 0 comments · Fixed by #5216
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Milestone

Comments

@westonruter
Copy link
Member

Feature description

In #5155 for #5013 we moved the Analytics screen to a drawer under the Advanced section on the Settings screen. As part of this, the admin menu item for Analytics was removed. However, users are accustomed to seeing this item. It would be helpful for users to retain this link but have it deep link to the settings screen like via /wp-admin/admin.php?page=amp-options#analytics-options-drawer

For that matter, each of the drawers should be deep-linkable. If the ID for the drawer is the location target/hash, then it should be scrolled into view, expanded, and focused when the component first mounts. This will be helpful to link users to Plugin Suppression, for example. This should also be the case for non-drawers as well. For example, there should be a way to link to the mobile redirection toggle so that it will scroll into view and be focused.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end labels Aug 6, 2020
@westonruter westonruter added this to the v2.0 milestone Aug 6, 2020
@johnwatkins0 johnwatkins0 self-assigned this Aug 10, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Aug 15, 2020
@kmyram kmyram assigned jwold and unassigned johnwatkins0 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants