Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine copy of Supported Templates section in admin screen #5046

Closed
amedina opened this issue Jul 14, 2020 · 7 comments · Fixed by #5044
Closed

Refine copy of Supported Templates section in admin screen #5046

amedina opened this issue Jul 14, 2020 · 7 comments · Fixed by #5044
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Milestone

Comments

@amedina
Copy link
Member

amedina commented Jul 14, 2020

  • Both sections heading must be bold
  • Make first-column heading concise: Content types available as AMP
  • In second column, make the Singular template non-selectable when it is required by other templates (e.g. Posts)
  • Remove notice Required...

Screen Shot 2020-07-14 at 4 12 34 PM

@amedina amedina added the Enhancement New feature or improvement of an existing one label Jul 14, 2020
@amedina amedina added this to the v1.6 milestone Jul 14, 2020
@westonruter
Copy link
Member

  • Both sections heading must be bold

Fixed in 32b1dd1

@westonruter
Copy link
Member

  • Remove notice Required...

Fixed in 9105286

@westonruter
Copy link
Member

  • Both sections heading must be bold
  • Make first-column heading concise: Content types available as AMP

What appears here is actually not intended to be a heading. It's a description. The heading got hidden accidentally. Now it appears as:

image

When in legacy mode, the heading is hidden since only the post types are shown in the first place:

image

@westonruter
Copy link
Member

  • In second column, make the Singular template non-selectable when it is required by other templates (e.g. Posts)

How about this as an alternative: When unchecking the Singular template, throw up a confirm() dialog:

image

Done in 0a6df8c.

@westonruter westonruter self-assigned this Jul 15, 2020
@amedina
Copy link
Member Author

amedina commented Jul 15, 2020

Love those changes. Very much aligned with the rest of the UI.

@westonruter
Copy link
Member

One other thing I noticed missing is a description paragraph to go under the Templates heading. So in 1084e18 I've added a paragraph that has a link to the template hierarchy handbook page:

image

@amedina
Copy link
Member Author

amedina commented Jul 15, 2020

Oh yes; that is needed.

The copy: Serve all templates as AMP regardless of what is being queried can be calibrated as well. We will do that on the copy overall pass.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants