-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the settings screen more visually appealing and reuse React components #4704
Comments
Question that has come up around the admin notice. Currently the AMP plugin has this notice that shows on the plugin options screen until the user dismisses it: I think our options for this new notice are:
Another option that would be a heavier lift mainly from the design standpoint would be to add more branding to the AMP options screen that is not in the form of a dismissible notice. Some of the existing dismissible notice could be repurposed for this. Then we could have a simple dismissible notice directing users to the setup wizard, and the same notice could be used on the plugin screen. |
I like this direction. Exploring it now in design. |
Took a stab at what the settings page could look like for the wizard onboarding notice. Also ended up giving a treatment of the entire settings page to see how it would feel. |
I like it! Modulo the copy (this needs work), it looks good. |
Awesome! Agree on tweaking the copy.
GitHub <[email protected]> wrote:
“I like it!
Modulo the copy (this needs work), it looks good.”
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@jwold I think we'll need to include this: |
Yes, that will be displayed when the “Serve all templates as AMP” toggle is off. |
The Content Types and Templates should go inside that Supported Templates box. They are conditionally shown if the toggle is off. Also note that the templates are presented as a hierarchy, so there will necessarily be indentations. |
Since we have built most of this UI already, I think it would make sense to build this page using the React components we already have (with a small amount of refactoring to ensure everything is reusable). It will work the same from a user standpoint, except for the small difference that the interface will be rendered client-side. |
I'm breaking the plugin screen notice into a separate issue and keeping this one focused on the settings screen because the two updates are functionally separate. |
Also need to incorporate the Plugin Suppression section: #4657 |
Feature description
Updating the UI of the settings screen to match the look and feel of the onboarding, as well as allow for changing the template mode.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: