Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the settings screen more visually appealing and reuse React components #4704

Closed
jwold opened this issue May 13, 2020 · 13 comments · Fixed by #4998
Closed

Make the settings screen more visually appealing and reuse React components #4704

jwold opened this issue May 13, 2020 · 13 comments · Fixed by #4998
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed UX WS:UX Work stream for UX/Front-end
Milestone

Comments

@jwold
Copy link
Collaborator

jwold commented May 13, 2020

Feature description

Updating the UI of the settings screen to match the look and feel of the onboarding, as well as allow for changing the template mode.

Acceptance criteria

Settings

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold jwold added this to the Sprint 31 milestone May 13, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@johnwatkins0
Copy link
Contributor

johnwatkins0 commented Jun 2, 2020

@jwold @westonruter @amedina

Question that has come up around the admin notice. Currently the AMP plugin has this notice that shows on the plugin options screen until the user dismisses it:

Screen Shot 2020-06-02 at 11 38 17 AM

I think our options for this new notice are:

  1. Have two dismissible notices on the AMP options screen. The new notice will be the same both on AMP options and on the plugins screen.
  2. Update the existing notice and display the same notice on the plugins screen as well.
  3. Update the existing notice on the AMP options screen, and display a different (probably simpler) notice on the plugins screen.

Another option that would be a heavier lift mainly from the design standpoint would be to add more branding to the AMP options screen that is not in the form of a dismissible notice. Some of the existing dismissible notice could be repurposed for this. Then we could have a simple dismissible notice directing users to the setup wizard, and the same notice could be used on the plugin screen.

@kmyram kmyram modified the milestones: Sprint 31, v1.6 Jun 3, 2020
@jwold
Copy link
Collaborator Author

jwold commented Jun 4, 2020

I like this direction. Exploring it now in design.

@jwold
Copy link
Collaborator Author

jwold commented Jun 23, 2020

Screen Shot 2020-06-23 at 9 12 34 AM

@kmyram kmyram added Groomed and removed Groomed labels Jun 23, 2020
@jwold
Copy link
Collaborator Author

jwold commented Jun 23, 2020

Took a stab at what the settings page could look like for the wizard onboarding notice. Also ended up giving a treatment of the entire settings page to see how it would feel.

Exploration

cc @amedina, @westonruter, @johnwatkins0

@amedina
Copy link
Member

amedina commented Jun 23, 2020

I like it!

Modulo the copy (this needs work), it looks good.

@jwold
Copy link
Collaborator Author

jwold commented Jun 23, 2020 via email

@johnwatkins0
Copy link
Contributor

@jwold I think we'll need to include this:

Screen Shot 2020-06-24 at 10 48 06 AM

@westonruter
Copy link
Member

Yes, that will be displayed when the “Serve all templates as AMP” toggle is off.

@jwold
Copy link
Collaborator Author

jwold commented Jun 24, 2020

Here's a stab at the remaining content:

Group 3058

@westonruter
Copy link
Member

The Content Types and Templates should go inside that Supported Templates box. They are conditionally shown if the toggle is off. Also note that the templates are presented as a hierarchy, so there will necessarily be indentations.

@johnwatkins0 johnwatkins0 changed the title Wizard notice upon plugin activation Wizard notice upon plugin activation and updated settings screen Jun 30, 2020
@johnwatkins0
Copy link
Contributor

Since we have built most of this UI already, I think it would make sense to build this page using the React components we already have (with a small amount of refactoring to ensure everything is reusable). It will work the same from a user standpoint, except for the small difference that the interface will be rendered client-side.

@johnwatkins0 johnwatkins0 changed the title Wizard notice upon plugin activation and updated settings screen Make the settings screen more visually appealing Jun 30, 2020
@johnwatkins0
Copy link
Contributor

I'm breaking the plugin screen notice into a separate issue and keeping this one focused on the settings screen because the two updates are functionally separate.

@kmyram kmyram added the Groomed label Jun 30, 2020
@johnwatkins0 johnwatkins0 changed the title Make the settings screen more visually appealing Make the settings screen more visually appealing and reuse React components Jun 30, 2020
@westonruter
Copy link
Member

Also need to incorporate the Plugin Suppression section: #4657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed UX WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants