Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide direct details of validation issue(s) within Paired Mode #4623

Closed
schlessera opened this issue Apr 24, 2020 · 1 comment
Closed

Provide direct details of validation issue(s) within Paired Mode #4623

schlessera opened this issue Apr 24, 2020 · 1 comment
Labels
Compatibility Tool Developer Tools for AMP Debugging Developer Tools Enhancement New feature or improvement of an existing one UX WS:UX Work stream for UX/Front-end

Comments

@schlessera
Copy link
Collaborator

Feature description

When I'm comparing my AMP page to my regular page in Paired Mode, as a developer, I'd like to be able to examine what the current validation issues are without leaving paired mode.

Right now, when I'm in Paired Mode, I can see the count of validation issues, but when I click on them to see them, I'm brought into the admin backend. This causes the Paired Mode to stop working, and show me a modal where I can either leave Paired Mode or get back to the actual page.

I'd like to have the ability to examine the validation issue details (at least an overview) directly from the Paired Mode without leaving it. This could be done by either adding a nested list to the admin bar submenu, or opening a modal within the AMP iframe when clicking on the validation issue warning.

Screenshots

Image 2020-04-24 at 9.48.32 AM.png

Image 2020-04-24 at 9.48.46 AM.png

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@schlessera schlessera added Compatibility Tool Developer Tools for AMP Debugging Enhancement New feature or improvement of an existing one UX labels Apr 24, 2020
@westonruter
Copy link
Member

Yeah, we should be working toward surfacing as much validation results in the admin bar as possible. Users should be able to make decisions about whether to remove or keep invalid markup from the context of the frontend where markup is shown. A complication here is that applying a change to remove/keep markup needs to result in a full-page reload, so the UI for managing the validation errors would itself need to be in a parent window in the same way that paired browsing has a UI outside of iframed windows. I've mentioned this before in #2316 (comment).

In the meantime, to address the specific issue here I think we should just automatically cause clicks in the admin bar to open in the top-level browsing context as opposed to navigating inside the iframe. Clicking a link in the admin bar would be an implicit exit of paired browsing.

@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility Tool Developer Tools for AMP Debugging Developer Tools Enhancement New feature or improvement of an existing one UX WS:UX Work stream for UX/Front-end
Projects
None yet
Development

No branches or pull requests

3 participants