Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to look up spec by name #4597

Closed
westonruter opened this issue Apr 16, 2020 · 3 comments
Closed

Add ability to look up spec by name #4597

westonruter opened this issue Apr 16, 2020 · 3 comments
Assignees
Labels
Groomed Validation WS:Core Work stream for Plugin core

Comments

@westonruter
Copy link
Member

Feature description

We need to more efficiently walk over the generated spec data, in particular to be able to find tag spec by a spec name. This will allow fleshing out validation errors in the UI with the full context and provide the user with information on amp.dev for more details.

Relates to #1420 and #4566.

  • Separate extension specs from tag specs. This eliminates having to look up extension specs from among tag specs.
  • Add ability to get a specific spec by name for a given tag, and use in the style sanitizer.
  • Add assertion that link rel=stylesheet for fonts spec is present.
  • Include extension_type in generated spec data in order to determine if an extension is a custom-template rather than custom-element.
  • Remove obsolete/unused AMP_Rule_Spec::$additional_allowed_tags.
  • Eliminate duplicate copies of spec in memory (e.g. $allowed_tags, $DEFAULT_ARGS['amp_allowed_tags'], and $args['amp_allowed_tags']).

Relates to #3080 and #4570.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold
Copy link
Collaborator

jwold commented Nov 10, 2020

#5585

Knowledge path admin umbrella. Want a little widget in the dashboard. Would like a little widget with info about latest news about AMP plugin and a set of links to twitter, amp blog, plugin site, YouTube channel.

@kmyram kmyram added the Groomed label Nov 10, 2020
@westonruter
Copy link
Member Author

Dependency for #1401.

@westonruter
Copy link
Member Author

Resolved by ampproject/amp-toolbox-php#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groomed Validation WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants