Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AMP-specific blocks #4556

Closed
westonruter opened this issue Apr 9, 2020 · 3 comments · Fixed by #5575
Closed

Deprecate AMP-specific blocks #4556

westonruter opened this issue Apr 9, 2020 · 3 comments · Fixed by #5575
Assignees
Labels
Editor Enhancement New feature or improvement of an existing one Groomed P1 Medium priority WS:Core Work stream for Plugin core
Milestone

Comments

@westonruter
Copy link
Member

Feature description

We currently have 8 AMP-specific blocks:

image

We added these originally because we were trying to add AMP features without thinking about long-term whether the blocks would be useful or used. I highly doubt that any of these blocks are being used, aside from AMP Timeago. Also, these blocks are only in Standard mode, further reducing the likelihood they are being used. (This restriction should go away once Bento AMPi is a thing since then they could be freely used on non-AMP pages.)

What's more is that these blocks all say “AMP”. The user shouldn't care these are AMP blocks. They should just be blocks, and they should be split out into separate plugins to only be added if the user even wants them. Functionality should be serving the needs of 80% of users; anything else should be split into other plugins.

So I recommend that we deprecate these blocks, preventing them from even showing up in the list unless one is being used on a page (or on the site?).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added this to the v1.6 milestone Apr 9, 2020
@kmyram kmyram added the P0 High priority label Apr 14, 2020
@kmyram kmyram modified the milestones: v1.6, Sprint 28 Apr 14, 2020
@westonruter westonruter added P1 Medium priority and removed P0 High priority labels Apr 16, 2020
@amedina amedina added the Enhancement New feature or improvement of an existing one label May 13, 2020
@kmyram kmyram modified the milestones: Sprint 28, v1.6 May 27, 2020
@westonruter westonruter removed this from the v1.6 milestone Jun 15, 2020
@westonruter westonruter added this to the v1.7 milestone Jul 5, 2020
@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
@westonruter
Copy link
Member Author

@jwold FYI

@westonruter
Copy link
Member Author

For the AMP MathML block, we can deprecate in favor of the MathML Block plugin, per adamsilverstein/mathml-block#32.

@westonruter westonruter self-assigned this Apr 25, 2021
@westonruter
Copy link
Member Author

QA Passed

When in Standard mode, I added an AMP MathML block to a post, among the other AMP-specific blocks that were provided. After upgrading to 2.1, editing that post shows only the AMP-specific block that I had already added to the post:

image

And if I start a new post, no such blocks are presented:

image

So this shows that the blocks are successfully deprecated by not being made available unless they are already being used in the post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Enhancement New feature or improvement of an existing one Groomed P1 Medium priority WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants