Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty: Desktop Expanded Menu is not right-aligned or full-height #3604

Closed
westonruter opened this issue Oct 22, 2019 · 1 comment · Fixed by #3606
Closed

Twenty Twenty: Desktop Expanded Menu is not right-aligned or full-height #3604

westonruter opened this issue Oct 22, 2019 · 1 comment · Fixed by #3606
Labels
Bug Something isn't working
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

Menus assigned to the “Desktop Expanded Menu” location do not open right-aligned or full-height in AMP.

Expected Behaviour

The desktop expanded menu should open being positioned to the right (when dir=ltr) and take up the full viewport height.

Steps to reproduce

  1. Activate Twenty Twenty
  2. Assign a menu to the “Desktop Expanded Menu” location.
  3. View the AMP page.
  4. Click the menu button.
  5. See incorrect position compared to non-AMP page

Screenshots

image

Screen Shot 2019-10-22 at 16 01 34


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added the Bug Something isn't working label Oct 22, 2019
@westonruter westonruter added this to the v1.4 milestone Oct 22, 2019
@csossi
Copy link

csossi commented Oct 28, 2019

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants