-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lightbox toggle for image linking to attachment pages #3579
Comments
@jamesozzie pointed out that images in AMP pages now automatically get lightboxing. See https://github.com/ampproject/amphtml/blob/master/spec/auto-lightbox.md Do we even need the lightbox toggle anymore? |
Closing (as per comment above) and will reopen if needed. |
Let's leave open because we should remove the toggle if indeed it is unnecessary. |
Closely related issue: #4591 |
Attachment pages are disabled in 6.4. Also, in 6.4 lightbox images are now supported in core. So in #7676 we're going to eliminate the AMP toggle when on 6.4. Otherwise, it doesn't seem necessary to anything further with this issue. |
Feature description
This is a follow-up to #3450. As proposed in #3460 (review), "the lightbox toggle should probably be prevented from even being made available when the image block has a link to the attachment page. Otherwise, the lightbox toggle has no effect when an attachment page is linked."
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: