You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding an iframe that contains mozallowfullscreen or webkitallowfullscreen attributes results in AMP validation errors being reported for those attributes being invalid. The AMP_Iframe_Sanitizer should just omit those entirely since amp-iframe will add them if needed if the allowfullscreen attribute is present. Example markup:
westonruter
changed the title
Invalid iframe attributes mozallowfullscreen and webkitallowfullscreen
Validation errors reported for invalid iframe attributes mozallowfullscreen and webkitallowfullscreen
Oct 2, 2019
Bug Description
Adding an iframe that contains
mozallowfullscreen
orwebkitallowfullscreen
attributes results in AMP validation errors being reported for those attributes being invalid. TheAMP_Iframe_Sanitizer
should just omit those entirely sinceamp-iframe
will add them if needed if theallowfullscreen
attribute is present. Example markup:Expected Behaviour
No validation errors should occur.
Steps to reproduce
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: