Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors reported for invalid iframe attributes mozallowfullscreen and webkitallowfullscreen #3425

Closed
westonruter opened this issue Oct 2, 2019 · 0 comments · Fixed by #3698
Assignees
Labels
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

Adding an iframe that contains mozallowfullscreen or webkitallowfullscreen attributes results in AMP validation errors being reported for those attributes being invalid. The AMP_Iframe_Sanitizer should just omit those entirely since amp-iframe will add them if needed if the allowfullscreen attribute is present. Example markup:

<iframe title="Why Backbone" id="talk_frame_48643" src="//speakerdeck.com/player/4648d440a3230130452522b217532879" width="640" height="480" style="border:0; padding:0; margin:0; background:transparent;" frameborder="0" allowtransparency="true" allowfullscreen="allowfullscreen" mozallowfullscreen="true" webkitallowfullscreen="true"></iframe>

Expected Behaviour

No validation errors should occur.

Steps to reproduce

  1. Add a new Embed block.
  2. Supply the URL https://speakerdeck.com/wallat/why-backbone
  3. Save draft
  4. Notice validation errors

Screenshots

Screen Shot 2019-10-02 at 14 41 52


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Bug Something isn't working Sanitizers labels Oct 2, 2019
@westonruter westonruter changed the title Invalid iframe attributes mozallowfullscreen and webkitallowfullscreen Validation errors reported for invalid iframe attributes mozallowfullscreen and webkitallowfullscreen Oct 2, 2019
@pierlon pierlon self-assigned this Nov 7, 2019
@westonruter westonruter added this to the v1.4.1 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants