-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right-Click: Display block settings menu #2990
Comments
Some thoughts so far after testing this out:
I guess we would keep the default menu in the Toolbar as well, and add the more relevant buttons to the new menu? We'll probably need a custom component for that anyway since it looks like
Thoughts? cc @swissspidy |
That sounds like a good summary and first step! 👍 |
Testing details on #2989 ticket |
Verified in QA |
Screencast can be found here - https://youtu.be/95GjenV63i8 |
Following discovery #2785, let's intercept right-click attempts to display the
BlockSettingsMenu
. This can be done by filteringeditor.BlockEdit
to wrap all blocks in a new container where we can add this event listener.Note: Considerations need to be put into accessibility, making sure that keyboard navigation and focus handling works as expected.
The text was updated successfully, but these errors were encountered: