Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a toggle to story editor to allow landscape view off or on - per story. #2969

Closed
cathibosco opened this issue Aug 5, 2019 · 6 comments

Comments

@cathibosco
Copy link

It would be useful to allow full landscape mode for any stories we need to on a "per story basis" with a toggle. Toggle landscape mode on or off as we choose.

Having the ability to control the output on a per story basis would be very useful for editors because assets vary and user experience may not always require full landscape. It is wonderful to have full landscape, it just may not always be necessary. 😍

@cathibosco cathibosco changed the title Consider adding a toggle to Story editor to allow landscape view off or on - per story. Consider adding a toggle to story editor to allow landscape view off or on - per story. Aug 5, 2019
@westonruter
Copy link
Member

This can be done now with the plugin I made which enables landscape support for a story if it has the landscape post tag: https://gist.github.com/westonruter/4e4ee2b5790c6218fab40a7b3f90331f

So the tag is essentially serving the purpose of the toggle.

@westonruter
Copy link
Member

See #2409 for overall landscape support.

@cathibosco
Copy link
Author

Terrific! Thank you Weston ⚡️

@jdelia
Copy link

jdelia commented Aug 20, 2019

Are you still planning to add a landscape toggle to the story document settings? I think that is the best option. For those that want that to be the default, they can set the filter to do so.

I'm not a fan of using the 'landscape' tag, as it is usually included in search results and I'm wondering what value that would have for visitors. Would one want to view all of the stories using that tag? Would they think that is referring to viewing scenic landscapes?

@westonruter
Copy link
Member

The landscape tag is just a temporary measure until #2409 is fully addressed. A tag was easy because no UI was needed for my little plugin. It could have added a toggle instead, but that would have taken longer. Just wanted to put together something quick and easy.

@jdelia
Copy link

jdelia commented Aug 20, 2019

Perfect. Thank you. Yes, I agree it is fine for a temporary measure. I am working on testing various archive pages for stories including categories and tags, hence my question. I'm going to leave the temporary landscape tag out of my next post - just focus on the story archive page for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants