Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress post embeds fail "wp-embedded-content" #288

Closed
laserjobs opened this issue Feb 29, 2016 · 5 comments
Closed

Wordpress post embeds fail "wp-embedded-content" #288

laserjobs opened this issue Feb 29, 2016 · 5 comments

Comments

@laserjobs
Copy link

Posts with Wordpress Embeds fail and give a error of "Unkown syntax errors" in the Search Console.
Unkown syntax errors: src=http://www.godairyfree.org/recipes/smores-ice-cream-sandwiches/embed#?secret=xxxxxxxx

webpage code:

<p><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="display:none;" src="http://www.godairyfree.org/recipes/smores-ice-cream-sandwiches/embed#?secret=xxxxxx" data-secret="xxxxxxxxx" width="600" height="338" title="Embedded WordPress Post" frameborder="0" marginwidth="0" marginheight="0" scrolling="no"></iframe></p>

AMP code:

<amp-iframe class="wp-embedded-content amp-wp-enforced-sizes" sandbox="allow-scripts" src="http://www.godairyfree.org/recipes/smores-ice-cream-sandwiches/embed#?secret=xxxxxxx" width="600" height="338" frameborder="0" sizes="(min-width: 600px) 600px, 100vw"><div placeholder="" class="amp-wp-iframe-placeholder"></div></amp-iframe>
@laserjobs
Copy link
Author

here is a link of the problem:
http://www.godairyfree.org/news/dairy-free-super-bowl-recipes/amp

@laserjobs
Copy link
Author

This seems like a core problem with Wordpress and the automatic post embed. How can we get around not using https?
https://www.ampproject.org/docs/guides/amp_replacements.html#display-an-iframe

@mjangda
Copy link
Contributor

mjangda commented Mar 2, 2016

In terms of rendering it, there's not much we can do since https is a strict requirement for AMP

We could, however, include a fallback element that has a link to the embed though.

@laserjobs
Copy link
Author

So it looks like it would validate with SSL but I am sure like myself there is many not using https

https://www. testsite.com/recipes/smores-ice-cream-sandwiches/embed#?secret=xxxxxxxxxxx Failed to load resource: net::ERR_SSL_PROTOCOL_ERROR

amp-iframe-0.1.max.js:264 GET https://www. testsite.com/recipes/healthy-vegan-queso-dip/embed net::ERR_SSL_PROTOCOL_ERRORZ.layoutCallback @ amp-iframe-0.1.max.js:264b.layoutCallback @ custom-element.js:732V.startLayout @ resources-impl.js:1685U.work_ @ resources-impl.js:986U.doPass_ @ resources-impl.js:596(anonymous function) @ resources-impl.js:122(anonymous function) @ pass.js:90

@mjangda
Copy link
Contributor

mjangda commented Aug 18, 2016

Fallback covered under #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants